Skip to content

Fix compilation on Cygwin (again) after #476 - #503

Closed
jon-turney wants to merge 1 commit into
mtrojnar:masterfrom
jon-turney:master
Closed

Fix compilation on Cygwin (again) after #476#503
jon-turney wants to merge 1 commit into
mtrojnar:masterfrom
jon-turney:master

Conversation

@jon-turney

Copy link
Copy Markdown
Contributor

Pull Request Type

  • Bug fix
  • New feature
  • Code style / formatting / renaming
  • Refactoring (no functional or API changes)
  • Build / CI related changes
  • Documentation
  • Other (please describe):

Current Behavior

$ make
[ 10%] Linking C executable osslsigncode.exe
/usr/lib/gcc/x86_64-pc-cygwin/14/../../../../x86_64-pc-cygwin/bin/ld: unrecognized option '-z'
/usr/lib/gcc/x86_64-pc-cygwin/14/../../../../x86_64-pc-cygwin/bin/ld: use the --help option for usage information
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/osslsigncode.dir/build.make:231: osslsigncode.exe] Error 1
make[1]: *** [CMakeFiles/Makefile2:89: CMakeFiles/osslsigncode.dir/all] Error 2
make: *** [Makefile:166: all] Error 2

New Behavior

Compiles without error

Scope of Changes

Also exclude use of ELF specific -z flags when target is Cygwin.

Testing

  • Existing tests
  • New tests added
  • Manual testing

License Declaration

  • [ x] I hereby agree to license my contribution under the project's license.

@mtrojnar mtrojnar closed this in 20b9766 Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant